Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

Conversation

@BewareMyPower
Copy link
Collaborator

@BewareMyPower BewareMyPower commented Feb 26, 2021

This version update is convenient for tests in real environment since there's no binary download url for original pulsar 2.8.0-rc-202101252233.

This PR fixes the API incompatibility problems that are introduced by apache/pulsar#9397 and apache/pulsar#9302.

Another significant change between these two versions is apache/pulsar#9338, which introduced metadata-store API for cluster resources. This PR fixed the test failure caused by it as well. Since KoP tests module only uses one MockZooKeeper to manage z-nodes, see KopProtocolHandlerTestBase#createMockZooKeeper, the mocked createConfigurationMetadataStore method returns mockedZooKeeper here instead of a mockedZooKeeperGlobal like what Pulsar did in MockedPulsarServiceBaseTest.

Besides, there's a test bug in testBrokerHandleTopicMetadataRequest that was not exposed by the previous Pulsar. This PR fixes it.

@BewareMyPower BewareMyPower changed the title Bump pulsar to 2.8.0-rc-202102252222 [WIP] Bump pulsar to 2.8.0-rc-202102252222 Feb 26, 2021
@BewareMyPower
Copy link
Collaborator Author

Some deleted classes should be recovered first.

@BewareMyPower
Copy link
Collaborator Author

It looks like Pulsar introduced some changes that make integration tests fail. I'll figure out the reason.

@BewareMyPower BewareMyPower force-pushed the bewaremypower/bump-pulsar-2.8.0-rc-202102252222 branch from 6d2469e to 649be78 Compare February 26, 2021 08:43
@BewareMyPower BewareMyPower self-assigned this Feb 26, 2021
@BewareMyPower BewareMyPower force-pushed the bewaremypower/bump-pulsar-2.8.0-rc-202102252222 branch from 649be78 to f46a225 Compare February 26, 2021 08:55
@BewareMyPower BewareMyPower changed the title [WIP] Bump pulsar to 2.8.0-rc-202102252222 Bump pulsar to 2.8.0-rc-202102252222 Feb 26, 2021
@jiazhai jiazhai merged commit 96eed9f into streamnative:master Feb 26, 2021
@BewareMyPower BewareMyPower deleted the bewaremypower/bump-pulsar-2.8.0-rc-202102252222 branch February 26, 2021 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants