This repository was archived by the owner on Jan 24, 2024. It is now read-only.
fix inner topic protection bug #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
changed the title
Collaborator
|
The checkstyle plugin has been upgraded, I think it's better to rebase to master first. |
Collaborator
Author
@BewareMyPower It run failed on basicProduceConsume test, not check style, i rerun it first. |
Collaborator
Author
|
The related PR in Pulsar is apache/pulsar#10529 |
Collaborator
|
Yeah, I just mean to ensure this PR could pass the latest checkstyle check. |
hangc0276
force-pushed
the
chenhang/fix_inner_topic_protection_bug
branch
from
b79f0fa to
8a1837a
Compare
Collaborator
Author
@BewareMyPower I have rebased the master. |
hangc0276
force-pushed
the
chenhang/fix_inner_topic_protection_bug
branch
from
8a1837a to
b46a306
Compare
tests/src/test/java/io/streamnative/pulsar/handlers/kop/InnerTopicProtectionTest.java
Outdated
Show resolved
Hide resolved
BewareMyPower
suggested changes
May 14, 2021
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Outdated
Show resolved
Hide resolved
hangc0276
force-pushed
the
chenhang/fix_inner_topic_protection_bug
branch
from
b46a306 to
5c58fe3
Compare
BewareMyPower
approved these changes
May 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
InnerTopicProtectionTest.I turn off the system topic produce test in
InnerTopicProtectionTestfirst, after fixed on Pulsar side for system topic check, and KOP merged the Pulsar master, i will turn on again.