This repository was archived by the owner on Jan 24, 2024. It is now read-only.
[BUGFIX] Fix wrong broker cache with multiple listeners #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@BewareMyPower @Demogorgon314 PTAL, Thanks. |
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KopEventManager.java
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KopEventManager.java
Outdated
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Outdated
Show resolved
Hide resolved
tests/src/test/java/io/streamnative/pulsar/handlers/kop/SaslPlainTestBase.java
Outdated
Show resolved
Hide resolved
Collaborator
|
My review is done, PTAL. |
Contributor
Author
Thanks review. Addressed done. PTAL |
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/EndPoint.java
Outdated
Show resolved
Hide resolved
tests/src/test/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandlerTest.java
Show resolved
Hide resolved
BewareMyPower
approved these changes
Sep 29, 2021
BewareMyPower
pushed a commit
that referenced
this pull request
Sep 30, 2021
Fixes #751 ### Motivation The brokerCache in the current AdminManger does not distinguish the listener name, which causes the wrong broker metadata to be returned when there are multiple listenerNames ### Modifications Support multiple listenerNames in BrokerCache
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #751
Motivation
The brokerCache in the current AdminManger does not distinguish the listener name, which causes the wrong broker metadata to be returned when there are multiple listenerNames
Modifications
Support multiple listenerNames in BrokerCache