This repository was archived by the owner on Jan 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaProtocolHandler.java
Outdated
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaProtocolHandler.java
Outdated
Show resolved
Hide resolved
BewareMyPower
suggested changes
Oct 9, 2021
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaProtocolHandler.java
Show resolved
Hide resolved
dockerzhang
approved these changes
Oct 11, 2021
...est/java/io/streamnative/pulsar/handlers/kop/coordinator/group/GroupMetadataManagerTest.java
Outdated
Show resolved
Hide resolved
BewareMyPower
approved these changes
Oct 11, 2021
...est/java/io/streamnative/pulsar/handlers/kop/coordinator/group/GroupMetadataManagerTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Kai Wang <kwang@streamnative.io>
Demogorgon314
approved these changes
Oct 11, 2021
Member
Demogorgon314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BewareMyPower
pushed a commit
that referenced
this pull request
Oct 20, 2021
This pull request fix #795. When KoP starts, check if the `__consumer_offsets` exist a) if exist, use the partition number already exist for `OffsetConfig` b) if not, use the default partition number in `broker.conf`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fix #795.
When KoP starts, check if the
__consumer_offsetsexista) if exist, use the partition number already exist for
OffsetConfigb) if not, use the default partition number in
broker.conf