Bump pulsar version to 2.9.0 #819
Conversation
BewareMyPower
left a comment
BewareMyPower
left a comment
There was a problem hiding this comment.
Could you avoid unnecessary changes as much as possible? Otherwise, it would cause many problems if we want to cherry-pick some PRs to branch-2.8 in future.
For example, I found MetadataStoreCacheLoader was already included in Pulsar 2.8.0. So changing MetadataCache<LocalBrokerData> to MetadataStoreCacheLoader is unnecessary.
We must avoid any change that is not related to the Pulsar upgrade.
Yeah. But does Pulsar 2.8.1.0 have some alternatives for
Similarly, avoid these changes for a Pulsar upgrade PR. For a PR that upgrades the Pulsar dependency, we should only retain code changes like #746. |
|
Thank you for pointing out. I'll recheck branch-2.8 and branch-2.9 APIs. And open another PR to fix it. |
Demogorgon314
force-pushed
the
impl/update-pulsar-dependencies-to-2.9.0
branch
from
965aa84 to
31936d6
Compare
Demogorgon314
changed the title
|
We should wait the rc release based on branch-2.9 first. |
|
I convert this PR to draft now. When 2.9.0 RC released I will update. |
## Motivation When we update Pulsar 2.9.0 dependencies in KoP, there will be some compatibility issues. like: * getPolicies API has changed ## Modifications * Update Pulsar dependencies to 2.9.0 * Change new getPolicies API
Currently, the KoP store message logic is in `KafkaRequestHandler`, to avoid duplicate code and easier to support idempotent produce, we must refactor the message storage logic. * Refactor message storage logic. * The `ReplicaManager` is a public interface to store messages, we should always use `ReplicaManager` to store the message in any situation. * `PartitionLog` mapping to Kafka is `Log`, the reason for using this name is to avoid naming conflict, like: `log.debug()`. * `PartitionLogManager` hold all `PartitionLog`, key is full partition name, value is `PartitionLog`. * Add fetch operation Fix conflicts made by #819. The `path` method was removed from master. Keep this method in branch-2.8.1.
2 participants
Motivation
When we update Pulsar 2.9.0 dependencies in KoP, there will be some compatibility issues. like:
Modifications