This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Fix flaky test: KafkaTopicConsumerManagerTest.testTopicManagerClose#846
Merged
BewareMyPower merged 1 commit intostreamnative:masterfrom Oct 26, 2021
Merged
Conversation
BewareMyPower
approved these changes
Oct 26, 2021
BewareMyPower
pushed a commit
that referenced
this pull request
Oct 26, 2021
Because the `KafkaRequestHandler.close()` is called by `channelInActive`, when `channelInActive` called, the tcp connection is already closed. We need ensure `topicManager.close()` is called. [channelInActive call root](https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/AbstractChannel.java#L765) We can easily reproduce by add some sleep in `KafkaRequestHandler.close()` like this: ```java @OverRide protected void close() { if (isActive.getAndSet(false)) { super.close(); try { TimeUnit.SECONDS.sleep(1); } catch (InterruptedException e) { e.printStackTrace(); } topicManager.close(); String clientHost = ctx.channel().remoteAddress().toString(); if (currentConnectedGroup.containsKey(clientHost)){ log.info("currentConnectedGroup remove {}", clientHost); currentConnectedGroup.remove(clientHost); } producePurgatory.shutdown(); fetchPurgatory.shutdown(); // update alive channel count stat RequestStats.ALIVE_CHANNEL_COUNT_INSTANCE.decrementAndGet(); } } ```
BewareMyPower
pushed a commit
that referenced
this pull request
Oct 29, 2021
Because the `KafkaRequestHandler.close()` is called by `channelInActive`, when `channelInActive` called, the tcp connection is already closed. We need ensure `topicManager.close()` is called. [channelInActive call root](https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/AbstractChannel.java#L765) We can easily reproduce by add some sleep in `KafkaRequestHandler.close()` like this: ```java @OverRide protected void close() { if (isActive.getAndSet(false)) { super.close(); try { TimeUnit.SECONDS.sleep(1); } catch (InterruptedException e) { e.printStackTrace(); } topicManager.close(); String clientHost = ctx.channel().remoteAddress().toString(); if (currentConnectedGroup.containsKey(clientHost)){ log.info("currentConnectedGroup remove {}", clientHost); currentConnectedGroup.remove(clientHost); } producePurgatory.shutdown(); fetchPurgatory.shutdown(); // update alive channel count stat RequestStats.ALIVE_CHANNEL_COUNT_INSTANCE.decrementAndGet(); } } ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the
KafkaRequestHandler.close()is called bychannelInActive, whenchannelInActivecalled, the tcp connection is already closed. We need ensuretopicManager.close()is called.channelInActive call root
We can easily reproduce by add some sleep in
KafkaRequestHandler.close()like this: