This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Make produce and fetch purgatory shared by all connections #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
added
release/2.8.1.x
release/2.9.0
type/bug
type/enhancement
Demogorgon314
approved these changes
Nov 13, 2021
BewareMyPower
added a commit
that referenced
this pull request
Nov 17, 2021
### Motivation Currently each connections holds two `DelayedOperationPurgatory` (purgatory) objects for produce and fetch requests. It's a waste of resources because each purgatory is backed by a time wheel and a reaper thread. In Kafka, these purgatories are held by a `ReplicaManager` instance, which is a global instance shared by all connections. ### Modifications Move `producePurgatory` and `fetchPurgatory` into `KafkaProtocolHandler`, and pass them to the constructors of `KafkaChannelInitializer` and `KafkaRequestHandler`. And move the `shutdown` calls from `KafkaRequestHandler#close` to `KafkaProtocolHandler#close`.
Collaborator
Author
|
Remove label |
BewareMyPower
added a commit
that referenced
this pull request
Nov 17, 2021
BewareMyPower
added a commit
that referenced
this pull request
Nov 17, 2021
### Motivation Currently each connections holds two `DelayedOperationPurgatory` (purgatory) objects for produce and fetch requests. It's a waste of resources because each purgatory is backed by a time wheel and a reaper thread. In Kafka, these purgatories are held by a `ReplicaManager` instance, which is a global instance shared by all connections. ### Modifications Move `producePurgatory` and `fetchPurgatory` into `KafkaProtocolHandler`, and pass them to the constructors of `KafkaChannelInitializer` and `KafkaRequestHandler`. And move the `shutdown` calls from `KafkaRequestHandler#close` to `KafkaProtocolHandler#close`.
Collaborator
Author
|
Instead of opening a new PR, I pushed a commit (29440e1) to migrate the necessary changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently each connections holds two
DelayedOperationPurgatory(purgatory) objects for produce and fetch requests. It's a waste of resources because each purgatory is backed by a time wheel and a reaper thread. In Kafka, these purgatories are held by aReplicaManagerinstance, which is a global instance shared by all connections.Modifications
Move
producePurgatoryandfetchPurgatoryintoKafkaProtocolHandler, and pass them to the constructors ofKafkaChannelInitializerandKafkaRequestHandler. And move theshutdowncalls fromKafkaRequestHandler#closetoKafkaProtocolHandler#close.