This repository was archived by the owner on Jan 24, 2024. It is now read-only.
[Docs] Add Monitor KoP link to main page #911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
added
doc
Collaborator
Author
|
PTAL @Huanli-Meng |
Huanli-Meng
approved these changes
Nov 17, 2021
Contributor
Huanli-Meng
left a comment
Huanli-Meng
left a comment
There was a problem hiding this comment.
LGTM. One more question, should we sync KoP Readme to SN hub? if need. We need to submit a PR in SN hub repo.
Collaborator
Author
|
@Huanli-Meng It's better not. Because it requires the docs using |
BewareMyPower
added a commit
that referenced
this pull request
Nov 17, 2021
### Motivation #389 exposed the metrics for KoP and added the docs. However, users cannot click into the metrics docs in the main web page. ### Modifications Add the link of metrics docs to README.md. In addition, sync docs/kop.md with README.md so that upgrade.md and reference-metrics.md can both be navigated from SN hub. Then remove the **Upgrade** section because it's duplicated with upgrade.md.
BewareMyPower
added a commit
that referenced
this pull request
Nov 17, 2021
### Motivation #389 exposed the metrics for KoP and added the docs. However, users cannot click into the metrics docs in the main web page. ### Modifications Add the link of metrics docs to README.md. In addition, sync docs/kop.md with README.md so that upgrade.md and reference-metrics.md can both be navigated from SN hub. Then remove the **Upgrade** section because it's duplicated with upgrade.md.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#389 exposed the metrics for KoP and added the docs. However, users cannot click into the metrics docs in the main web page.
Modifications
Add the link of metrics docs to README.md. In addition, sync docs/kop.md with README.md so that upgrade.md and reference-metrics.md can both be navigated from SN hub. Then remove the Upgrade section because it's duplicated with upgrade.md.