This repository was archived by the owner on Jan 24, 2024. It is now read-only.
AdminManager: handle properly async deletePartitionedTopic #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/AdminManager.java
Show resolved
Hide resolved
BewareMyPower
added
type/enhancement
Contributor
Author
|
patch updated @BewareMyPower |
BewareMyPower
approved these changes
Dec 22, 2021
BewareMyPower
pushed a commit
that referenced
this pull request
Dec 29, 2021
In AdminManager there are some points in which we are not using correctly CompletableFuture. This patch fixes deletePartitionedTopic and a couple of other parts. This patch is trivial rework, no need to add tests
BewareMyPower
pushed a commit
that referenced
this pull request
Dec 29, 2021
In AdminManager there are some points in which we are not using correctly CompletableFuture. This patch fixes deletePartitionedTopic and a couple of other parts. This patch is trivial rework, no need to add tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AdminManager there are some points in which we are not using correctly CompletableFuture.
This patch fixes deletePartitionedTopic and a couple of other parts.
This patch is trivial rework, no need to add tests