This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Fix list topic and list offset behavior #991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Outdated
Show resolved
Hide resolved
Collaborator
|
LGTM except a comment about code style. |
BewareMyPower
approved these changes
Dec 28, 2021
BewareMyPower
pushed a commit
that referenced
this pull request
Dec 29, 2021
#908 ### Motivation In the current implementation, list topic and list offset might get the wrong response, because the authorized future is not finished yet. We need to make sure to authorize future finish correctly. ### Modifications * Ensure all future is finished when the response
BewareMyPower
pushed a commit
that referenced
this pull request
Dec 29, 2021
#908 ### Motivation In the current implementation, list topic and list offset might get the wrong response, because the authorized future is not finished yet. We need to make sure to authorize future finish correctly. ### Modifications * Ensure all future is finished when the response
eolivelli
pushed a commit
to eolivelli/kop
that referenced
this pull request
Feb 24, 2022
streamnative#908 ### Motivation In the current implementation, list topic and list offset might get the wrong response, because the authorized future is not finished yet. We need to make sure to authorize future finish correctly. ### Modifications * Ensure all future is finished when the response (cherry picked from commit dc4d080)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#908
Motivation
In the current implementation, list topic and list offset might get the wrong response, because the authorized future is not finished yet. We need to make sure to authorize future finish correctly.
Modifications