Skip to content

Conversation

@mattisonchao
Copy link
Member

Motivation

See the tracker: #369

Modifications

  • Support MQTT-5: Request problem information

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • no-need-doc

@mattisonchao mattisonchao requested review from a team and codelipenghui as code owners June 5, 2022 13:28
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2022

Codecov Report

Merging #655 (54e5714) into master (0d0af93) will decrease coverage by 0.09%.
The diff coverage is 34.32%.

@@             Coverage Diff              @@
##             master     #655      +/-   ##
============================================
- Coverage     77.97%   77.87%   -0.10%     
- Complexity      910      913       +3     
============================================
  Files           108      108              
  Lines          3923     3928       +5     
  Branches        276      287      +11     
============================================
  Hits           3059     3059              
- Misses          702      705       +3     
- Partials        162      164       +2     
Impacted Files Coverage Δ
...s/mqtt/proxy/MQTTProxyProtocolMethodProcessor.java 77.89% <0.00%> (-0.86%) ⬇️
...lsar/handlers/mqtt/support/Qos1PublishHandler.java 64.81% <0.00%> (ø)
...qtt/support/MQTTBrokerProtocolMethodProcessor.java 78.84% <41.17%> (-0.99%) ⬇️
...lsar/handlers/mqtt/messages/MqttPropertyUtils.java 89.47% <100.00%> (-0.78%) ⬇️
.../pulsar/handlers/mqtt/messages/ack/MqttPubAck.java 87.80% <100.00%> (+0.30%) ⬆️
...handlers/mqtt/restrictions/ClientRestrictions.java 68.00% <100.00%> (+1.33%) ⬆️
...e/pulsar/handlers/mqtt/utils/PulsarTopicUtils.java 78.26% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d0af93...54e5714. Read the comment docs.

@Technoboy- Technoboy- merged commit dafac99 into streamnative:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants