Skip to content

Conversation

@Technoboy-
Copy link
Contributor

Master Issue: #369

Motivation

Support MQTT-5 Will Message with Content type, Correlation data, Payload format indicator, Response topic

Publish message with Payload format indicator

Documentation

  • no-need-doc

@Technoboy- Technoboy- requested review from a team and codelipenghui as code owners June 15, 2022 09:29
@Technoboy- Technoboy- self-assigned this Jun 15, 2022
@Technoboy- Technoboy- changed the title Support MQTT5-5 will message with properties. Support MQTT-5 will message with properties. Jun 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #666 (7ff3775) into master (0d0af93) will increase coverage by 0.12%.
The diff coverage is 68.78%.

@@             Coverage Diff              @@
##             master     #666      +/-   ##
============================================
+ Coverage     77.97%   78.10%   +0.12%     
- Complexity      910      934      +24     
============================================
  Files           108      108              
  Lines          3923     4014      +91     
  Branches        276      299      +23     
============================================
+ Hits           3059     3135      +76     
- Misses          702      712      +10     
- Partials        162      167       +5     
Impacted Files Coverage Δ
...s/mqtt/proxy/MQTTProxyProtocolMethodProcessor.java 77.89% <0.00%> (-0.86%) ⬇️
...lsar/handlers/mqtt/support/Qos1PublishHandler.java 64.81% <0.00%> (ø)
...qtt/support/MQTTBrokerProtocolMethodProcessor.java 78.84% <41.17%> (-0.99%) ⬇️
...ar/handlers/mqtt/utils/PulsarMessageConverter.java 88.49% <91.22%> (+2.78%) ⬆️
...lsar/handlers/mqtt/messages/MqttPropertyUtils.java 89.47% <100.00%> (-0.78%) ⬇️
.../pulsar/handlers/mqtt/messages/ack/MqttPubAck.java 87.80% <100.00%> (+0.30%) ⬆️
...handlers/mqtt/restrictions/ClientRestrictions.java 68.00% <100.00%> (+1.33%) ⬆️
...e/pulsar/handlers/mqtt/utils/MqttMessageUtils.java 89.53% <100.00%> (+3.38%) ⬆️
...native/pulsar/handlers/mqtt/utils/WillMessage.java 100.00% <100.00%> (ø)
...pulsar/handlers/mqtt/MQTTCommonInboundHandler.java 77.94% <0.00%> (-4.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3659389...7ff3775. Read the comment docs.

@Technoboy- Technoboy- merged commit e9ec63b into streamnative:master Jun 15, 2022
@Balaji-P-Amat
Copy link

Looking for support for properties. Is there a released Mop version with support for properties?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants