Skip to content

Conversation

@Technoboy-
Copy link
Contributor

@Technoboy- Technoboy- commented Jun 21, 2022

Master Issue: #369

Motivation

Support MQTT-5 ConnectAck with Max Qos and response information.

Documentation

  • no-need-doc

@codecov-commenter
Copy link

Codecov Report

Merging #677 (71bfa9f) into master (0d0af93) will increase coverage by 0.27%.
The diff coverage is 74.67%.

@@             Coverage Diff              @@
##             master     #677      +/-   ##
============================================
+ Coverage     77.97%   78.24%   +0.27%     
- Complexity      910      953      +43     
============================================
  Files           108      108              
  Lines          3923     4073     +150     
  Branches        276      307      +31     
============================================
+ Hits           3059     3187     +128     
- Misses          702      717      +15     
- Partials        162      169       +7     
Impacted Files Coverage Δ
...streamnative/pulsar/handlers/mqtt/MQTTService.java 82.60% <0.00%> (-1.84%) ⬇️
...s/mqtt/proxy/MQTTProxyProtocolMethodProcessor.java 77.89% <0.00%> (-0.86%) ⬇️
...lsar/handlers/mqtt/support/Qos1PublishHandler.java 64.81% <0.00%> (ø)
...qtt/support/MQTTBrokerProtocolMethodProcessor.java 78.84% <41.17%> (-0.99%) ⬇️
.../streamnative/pulsar/handlers/mqtt/Connection.java 89.47% <71.42%> (-0.53%) ⬇️
...lsar/handlers/mqtt/support/WillMessageHandler.java 78.04% <71.42%> (-1.37%) ⬇️
...sar/handlers/mqtt/messages/ack/MqttConnectAck.java 78.75% <75.00%> (-1.25%) ⬇️
...handlers/mqtt/restrictions/ClientRestrictions.java 66.66% <80.00%> (ø)
...amnative/pulsar/handlers/mqtt/utils/MqttUtils.java 80.00% <80.00%> (-3.34%) ⬇️
...ar/handlers/mqtt/utils/PulsarMessageConverter.java 89.16% <92.30%> (+3.45%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c8f45...71bfa9f. Read the comment docs.

@Technoboy- Technoboy- merged commit 617fba1 into streamnative:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants