Skip to content

Conversation

@mattisonchao
Copy link
Member

Motivation

Support MQTT-5 property topicAliasMaximum

Modifications

  • Support MQTT-5 property topicAliasMaximum

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@mattisonchao mattisonchao force-pushed the support_topic_alias_maximum branch from d8481f9 to 4f0ad8c Compare June 26, 2022 09:31
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2022

Codecov Report

Merging #686 (97814bc) into master (1aba3fe) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #686      +/-   ##
============================================
+ Coverage     78.24%   78.30%   +0.05%     
- Complexity      954      956       +2     
============================================
  Files           108      108              
  Lines          4095     4106      +11     
  Branches        309      309              
============================================
+ Hits           3204     3215      +11     
  Misses          719      719              
  Partials        172      172              
Impacted Files Coverage Δ
.../streamnative/pulsar/handlers/mqtt/Connection.java 88.60% <100.00%> (+0.07%) ⬆️
...lsar/handlers/mqtt/messages/MqttPropertyUtils.java 90.24% <100.00%> (+0.77%) ⬆️
...sar/handlers/mqtt/messages/ack/MqttConnectAck.java 77.00% <100.00%> (+1.46%) ⬆️
...handlers/mqtt/restrictions/ClientRestrictions.java 67.85% <100.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aba3fe...97814bc. Read the comment docs.

@Technoboy- Technoboy- merged commit 6c11886 into streamnative:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants