-
Notifications
You must be signed in to change notification settings - Fork 70
Add delete cmd for Pulsar Functions #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Contributor
Author
sijie
requested changes
Sep 3, 2019
pkg/ctl/functions/delete.go
Outdated
| Out: "Deleted successfully", | ||
| } | ||
|
|
||
| out = append(out, successOut) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a few error cases.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OUTPUT:
# normal output
Deleted successfully
# You must specify a name for the Pulsar Functions or a FQFN, please check the --name args
[✖] you must specify a name for the function or a Fully Qualified Function Name (FQFN)
# The name of Pulsar Functions doesn't exist, please check the --name args
[✖] code: 404 reason: Function <your function name> doesn't exist
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
sijie
requested changes
Sep 3, 2019
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
sijie
approved these changes
Sep 3, 2019
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com> Master Issue: streamnative/pulsarctl#2 Add delete cmd for Pulsar Functions, the output as follows: ``` USED FOR: This command is used for delete a Pulsar Function that is running on a Pulsar cluster. REQUIRED PERMISSION: This command requires super-user permissions. EXAMPLES: #Delete a Pulsar Function that is running on a Pulsar cluster pulsarctl functions create --tenant public --namespace default --name <the name of Pulsar Functions> #Delete a Pulsar Function that is running on a Pulsar cluster with instance ID pulsarctl functions create --tenant public --namespace default --name <the name of Pulsar Functions> --instance-id 1 #Delete a Pulsar Function that is running on a Pulsar cluster with FQFN pulsarctl functions delete --fqfn tenant/namespace/name [eg: public/default/ExampleFunctions] OUTPUT: #normal output Deleted successfully Usage: pulsarctl functions delete [flags] Aliases: delete, delete FunctionsConfig flags: --fqfn string The Fully Qualified Function Name (FQFN) for the function --tenant string The tenant of a Pulsar Function --namespace string The namespace of a Pulsar Function --name string The name of a Pulsar Function ```
tisonkun
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Aug 16, 2023
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com> Master Issue: streamnative/pulsarctl#2 Add delete cmd for Pulsar Functions, the output as follows: ``` USED FOR: This command is used for delete a Pulsar Function that is running on a Pulsar cluster. REQUIRED PERMISSION: This command requires super-user permissions. EXAMPLES: #Delete a Pulsar Function that is running on a Pulsar cluster pulsarctl functions create --tenant public --namespace default --name <the name of Pulsar Functions> #Delete a Pulsar Function that is running on a Pulsar cluster with instance ID pulsarctl functions create --tenant public --namespace default --name <the name of Pulsar Functions> --instance-id 1 #Delete a Pulsar Function that is running on a Pulsar cluster with FQFN pulsarctl functions delete --fqfn tenant/namespace/name [eg: public/default/ExampleFunctions] OUTPUT: #normal output Deleted successfully Usage: pulsarctl functions delete [flags] Aliases: delete, delete FunctionsConfig flags: --fqfn string The Fully Qualified Function Name (FQFN) for the function --tenant string The tenant of a Pulsar Function --namespace string The namespace of a Pulsar Function --name string The name of a Pulsar Function ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com
Master Issue: #2
Add delete cmd for Pulsar Functions, the output as follows: