Add tenants related commands #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
requested changes
Sep 4, 2019
sijie
added
area/pulsar/tenants
type/task
sijie
requested changes
Sep 5, 2019
| assert.False(t, strings.Contains(out.String(), "delete-tenant-test")) | ||
| } | ||
|
|
||
| func TestDeleteTenantArgsError(t *testing.T) { |
Member
There was a problem hiding this comment.
please add test case to cover deleting a non-existent tenant
pkg/ctl/tenant/update.go
Outdated
| return vc.NameError | ||
| } | ||
|
|
||
| if data.AllowedClusters == nil && data.AdminRoles == nil { |
Member
Author
There was a problem hiding this comment.
umm, I think if you don't want to change anything so why you want to execute update tenant.
Member
There was a problem hiding this comment.
a user can remove all the allowed clusters and admin roles by specifying empty list of allowed clusters and roles, no?
Member
Author
There was a problem hiding this comment.
update Updates the configuration for a tenant
Usage: update [options] tenant-name
Options:
--admin-roles, -r
Comma separated list of auth principal allowed to administrate the
tenant. If empty the current set of roles won't be modified
--allowed-clusters, -c
Comma separated allowed clusters. If omitted, the current set of
clusters will be preserved
I used java admin to test but there is no changes with an empty list.
sijie
requested changes
Sep 7, 2019
pkg/ctl/tenant/delete.go
Outdated
| func deleteTenantCmd(vc *cmdutils.VerbCmd) { | ||
| var desc pulsar.LongDescription | ||
|
|
||
| desc.CommandUsedFor = "This command is used for deleting a tenant and all namespaces and topics under it will be deleted." |
Member
There was a problem hiding this comment.
two questions here:
- does pulsar allow deleting a non-empty tenant?
- do we have a test case to cover the case?
Member
|
@zymap it seems that my comment regarding deleting a non-empty tenant is not addressed. PTAL and make sure you have responded to all my comments. |
sijie
requested changes
Sep 9, 2019
sijie
approved these changes
Sep 9, 2019
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
Master issue: streamnative/pulsarctl#2 The pull requests add all tenant commands.
tisonkun
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Aug 16, 2023
Master issue: streamnative/pulsarctl#2 The pull requests add all tenant commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master issue: #2
The pull requests add all tenant commands.