-
Notifications
You must be signed in to change notification settings - Fork 70
Add schema, offload and compaction commands of namespaces for pulsasrctl #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| func SetCompactionThresholdCmd(vc *cmdutils.VerbCmd) { | ||
| var desc LongDescription | ||
| desc.CommandUsedFor = "This command is used for setting compaction threshold for a namespace." | ||
| desc.CommandPermission = "This command requires super-user permissions and broker has write policies permission." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why super-user? and what does "broker has write policies permission" mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protected void internalSetCompactionThreshold(long newThreshold) {
validateSuperUserAccess();
validatePoliciesReadOnlyAccess();
broker has write policies permission
It will check the broker is allowed to read-write operations in the global zookeeper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it requires super-user access. so please document this in the spreadsheet and we need to improve it.
broker has write policies permission
Okay we need to document this. Because not everyone will know what does that mean. So pleasee improve the message here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
|
@zymap Please rebase master code |
|
@wolfstudy ok |
|
please rebase to master and fix CI |
|
@sijie PTAL. Thanks |
|
Please rebase to latest master |
…ctl (streamnative/pulsarctl#64) Command List set-schema-validation-enforced get-schema-validation-enforced set-schema-autoupdate-strategy get-schema-autoupdate-strategy set-offload-threshold get-offload-threshold set-offload-deletion-lag get-offload-deletion-lag clear-offload-deletion-lag set-compaction-threshold get-compaction-threshold
…ctl (streamnative/pulsarctl#64) Command List set-schema-validation-enforced get-schema-validation-enforced set-schema-autoupdate-strategy get-schema-autoupdate-strategy set-offload-threshold get-offload-threshold set-offload-deletion-lag get-offload-deletion-lag clear-offload-deletion-lag set-compaction-threshold get-compaction-threshold
Command List
set-schema-validation-enforced
get-schema-validation-enforced
set-schema-autoupdate-strategy
get-schema-autoupdate-strategy
set-offload-threshold
get-offload-threshold
set-offload-deletion-lag
get-offload-deletion-lag
clear-offload-deletion-lag
set-compaction-threshold
get-compaction-threshold