Add set and get commands for MaxConsumersPerSub and MaxConsumersPerTopic and maxProduersPerTopic #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pic and maxProduersPerTopic --- *Modifications* Add command `set-max-consumers-per-subscription` Add command `get-max-consumers-per-subscription` Add command `set-max-consumers-per-topic` Add command `get-max-consumers-per-topic` Add command `set-max-producers-per-topic` Add command `get-max-producers-per-topic`
sijie
requested changes
Sep 18, 2019
Member
sijie
left a comment
sijie
left a comment
There was a problem hiding this comment.
Can you please use a consistent naming pattern for the files?
Also I have made a comment to you and @wolfstudy about the file naming pattern. Can you please use a consistent pattern for organizing the files.
We have two ways on organizing the code:
https://github.com/streamnative/pulsarctl/tree/master/pkg/ctl/topic
https://github.com/streamnative/pulsarctl/tree/master/pkg/ctl/cluster
I would suggest creating a follow up pull request to unify these two different approaches.
e.g. if we take the approach we applied in topic, the cluster one should be organized in the following way.
cluster/crud
cluster/failure_domain/
cluster/anti_affinity_group/
also since you two are working together on this project, please talk to each other closely about this kind of stuffs and make the coding convention consistent.
sijie
added
area/pulsar/namespaces
type/task
Contributor
|
@zymap please rebase master code |
Member
Author
|
@wolfstudy ok |
Member
|
please address my comments and rebase to latest master |
Member
Author
|
@sijie PTAL. Thanks |
sijie
approved these changes
Oct 12, 2019
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
…pic and maxProduersPerTopic (streamnative/pulsarctl#67) *Modifications* Add command `set-max-consumers-per-subscription` Add command `get-max-consumers-per-subscription` Add command `set-max-consumers-per-topic` Add command `get-max-consumers-per-topic` Add command `set-max-producers-per-topic` Add command `get-max-producers-per-topic`
tisonkun
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Aug 16, 2023
…pic and maxProduersPerTopic (streamnative/pulsarctl#67) *Modifications* Add command `set-max-consumers-per-subscription` Add command `get-max-consumers-per-subscription` Add command `set-max-consumers-per-topic` Add command `get-max-consumers-per-topic` Add command `set-max-producers-per-topic` Add command `get-max-producers-per-topic`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
Add command
set-max-consumers-per-subscriptionAdd command
get-max-consumers-per-subscriptionAdd command
set-max-consumers-per-topicAdd command
get-max-consumers-per-topicAdd command
set-max-producers-per-topicAdd command
get-max-producers-per-topic