Skip to content

Add license header check for all files #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sijie merged 3 commits into from
Sep 24, 2019
Merged

Add license header check for all files #69

sijie merged 3 commits into from
Sep 24, 2019

Conversation

@zymap
Copy link
Member

@zymap zymap commented Sep 20, 2019 •
edited by sijie
Loading

Fixes: #65

@zymap zymap requested a review from sijie September 20, 2019 03:27
@zymap zymap self-assigned this Sep 20, 2019
@sijie sijie mentioned this pull request Sep 20, 2019
Closed
29 tasks
@wolfstudy wolfstudy self-requested a review September 23, 2019 02:12
wolfstudy
wolfstudy approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@wolfstudy wolfstudy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@sijie please review this pull request, thanks.

In here, we treat the check of the license header as a test file, so when we execute go test ./..., we will check all files for the correct license header.

@sijie
Copy link
Member

sijie commented Sep 24, 2019

@wolfstudy @zymap we can go with this approach for now. but is there any generic license header check tools in go?

@sijie sijie added the type/task Indicates a chore or a small item of work label Sep 24, 2019
@sijie sijie added this to the 0.0.1 milestone Sep 24, 2019
@sijie sijie merged commit 6bad265 into master Sep 24, 2019
@sijie sijie deleted the license_check branch September 24, 2019 06:12
@wolfstudy
Copy link
Contributor

wolfstudy commented Sep 24, 2019

@wolfstudy @zymap we can go with this approach for now. but is there any generic license header check tools in go?

There is currently no universal license header checker in the go community.

tisonkun pushed a commit to tisonkun/pulsar-client-go that referenced this pull request Aug 15, 2023
@zymap @tisonkun
Add license header check for all files (streamnative/pulsarctl#69)
241ceed 
Fixes: streamnative/pulsarctl#65
tisonkun pushed a commit to apache/pulsar-client-go that referenced this pull request Aug 16, 2023
@zymap @tisonkun
Add license header check for all files (streamnative/pulsarctl#69)
13c4241 
Fixes: streamnative/pulsarctl#65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sijie sijie sijie approved these changes

+1 more reviewer

@wolfstudy wolfstudy wolfstudy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zymap zymap

Labels

type/task Indicates a chore or a small item of work

Projects

None yet

Milestone

0.1.0

Development

Successfully merging this pull request may close these issues.

Add Apache License Header and enforce license header check in CI

4 participants

@zymap @sijie @wolfstudy