Skip to content

Conversation

@wolfstudy
Copy link
Contributor

Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com

Add Readme.md for pulsarctl

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy wolfstudy self-assigned this Sep 26, 2019
@wolfstudy wolfstudy requested review from sijie and zymap September 26, 2019 03:12
@wolfstudy
Copy link
Contributor Author

@sijie @zymap PTAL

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@sijie sijie mentioned this pull request Sep 26, 2019
29 tasks
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
Copy link
Contributor Author

@sijie I first added a Chinese-related document of How to add a new command. After the content is determined, I will translate it into a related English document.

Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Chinese version of developer guide looks good to me. Please add the english version. Once you add the english version, please loop in Yu for reviewing it.

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
Copy link
Contributor Author

@jennifer88huang @Anonymitaet This pull request is about the documentation, please help confirm the language organization and grammar issues.

Thanks.

@Jennifer88huang-zz
Copy link

@Anonymitaet Could you please help review this PR? Thank you.

@Anonymitaet
Copy link

@jennifer88huang glad to help

@Anonymitaet
Copy link

Anonymitaet commented Oct 12, 2019

@wolfstudy I've finished my review but failed to submit.

I've tried many times but it always shows:
image

Will try later.

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@Anonymitaet
Copy link

I've tried several times (including change a web browser to submit) but failed again.

I found that many people have encountered this problem as well, but GitHub does not provide a solution officially.

I've reported this issue to GitHub and waiting for a response.

@wolfstudy
Copy link
Contributor Author

wolfstudy commented Oct 12, 2019

@Anonymitaet Is it convenient to copy your review comments to google docs as screenshots? Or you can try to split your comments.

@Anonymitaet
Copy link

@wolfstudy I've tried several methods to capture a scrolling screenshot but all failed, I guess the reason is that this file is too large (112 comments).
I can give you my GitHub account and password, could you please log in and check my suggestions?

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
Copy link
Contributor Author

@Anonymitaet done, PTAL again.

@Anonymitaet
Copy link

Anonymitaet commented Oct 14, 2019

@wolfstudy After I click Approve button, it shows the unicorn image as well.

So leave my comment here, I approve this PR, you can continue your work.

@wolfstudy
Copy link
Contributor Author

ping @sijie PTAL again, thanks.

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
Copy link
Contributor Author

@jennifer88huang done PTAL.

@wolfstudy
Copy link
Contributor Author

ping @sijie PTAL

1 similar comment
@wolfstudy
Copy link
Contributor Author

ping @sijie PTAL

@sijie sijie added this to the 0.0.1 milestone Oct 16, 2019
@sijie sijie merged commit 07bba9e into master Oct 16, 2019
@sijie sijie deleted the xiaolong/readme-file branch October 16, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants