-
Notifications
You must be signed in to change notification settings - Fork 70
Add Readme.md for pulsarctl #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
|
@sijie I first added a Chinese-related document of |
sijie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Chinese version of developer guide looks good to me. Please add the english version. Once you add the english version, please loop in Yu for reviewing it.
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
|
@jennifer88huang @Anonymitaet This pull request is about the documentation, please help confirm the language organization and grammar issues. Thanks. |
|
@Anonymitaet Could you please help review this PR? Thank you. |
|
@jennifer88huang glad to help |
|
@wolfstudy I've finished my review but failed to submit. I've tried many times but it always shows: Will try later. |
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
|
I've tried several times (including change a web browser to submit) but failed again. I found that many people have encountered this problem as well, but GitHub does not provide a solution officially. I've reported this issue to GitHub and waiting for a response. |
|
@Anonymitaet Is it convenient to copy your review comments to google docs as screenshots? Or you can try to split your comments. |
|
@wolfstudy I've tried several methods to capture a scrolling screenshot but all failed, I guess the reason is that this file is too large (112 comments). |
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
|
@Anonymitaet done, PTAL again. |
|
@wolfstudy After I click Approve button, it shows the unicorn image as well. So leave my comment here, I approve this PR, you can continue your work. |
|
ping @sijie PTAL again, thanks. |
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
|
@jennifer88huang done PTAL. |
|
ping @sijie PTAL |
1 similar comment
|
ping @sijie PTAL |

Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com
Add Readme.md for pulsarctl