Skip to content

Conversation

@zymap
Copy link
Member

@zymap zymap commented Aug 27, 2019

Master issue: #2

Output:

➜  pulsarctl git:(clusters_delete) ./pulsarctl clusters delete -h
USED FOR:
    This command is used for deleting an existing cluster.

REQUIRED PERMISSION:
    This command requires super-user permissions.

EXAMPLES:
    #deleting the cluster named <cluster-name>
    pulsarctl clusters delete <cluster-name>

OUTPUT:
    #normal output
    Cluster <cluster-name> delete successfully.

    #output of doesn't specified a cluster name
    only one argument is allowed to be used as a name

    #output of cluster doesn't exist
    [✖]  code: 404 reason: Cluster does not exist

Usage: pulsarctl clusters delete [flags]

Aliases: delete, delete

Common flags:
  -s, --admin-service-url string   The admin web service url that pulsarctl connects to. (default "http://localhost:8080")
  -C, --color string               toggle colorized logs (true,false,fabulous) (default "true")
  -h, --help                       help for this command
  -v, --verbose int                set log level, use 0 to silence, 4 for debugging (default 3)

Use 'pulsarctl clusters delete [command] --help' for more information about a command.

@zymap zymap changed the title [WIP] Add command cluster delete Add command cluster delete Aug 27, 2019
@zymap zymap changed the title Add command cluster delete [WIP] Add command cluster delete Aug 27, 2019
Copy link
Contributor

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

@zymap zymap added this to the 0.0.1 milestone Aug 28, 2019
@zymap zymap changed the title [WIP] Add command cluster delete Add command cluster delete Aug 28, 2019
@sijie sijie mentioned this pull request Aug 28, 2019
29 tasks
desc := pulsar.LongDescription{}
desc.CommandUsedFor = "This command is used for getting the cluster data of the specified cluster."
desc.CommandPermission = "This command requires super-user permissions."
desc.CommandPermission = "All users can use."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two problems here:

@zymap zymap mentioned this pull request Aug 29, 2019
@sijie sijie closed this in #14 Aug 29, 2019
sijie pushed a commit that referenced this pull request Aug 29, 2019
Master issue: #2 

closes #8 

Output: 

```
➜  pulsarctl git:(clusters_delete) ./pulsarctl clusters delete -h
USED FOR:
    This command is used for deleting an existing cluster.

REQUIRED PERMISSION:
    This command requires super-user permissions.

EXAMPLES:
    #deleting the cluster named <cluster-name>
    pulsarctl clusters delete <cluster-name>

OUTPUT:
    #normal output
    Cluster <cluster-name> delete successfully.

    #output of doesn't specified a cluster name
    only one argument is allowed to be used as a name

    #output of cluster doesn't exist
    [✖]  code: 404 reason: Cluster does not exist

Usage: pulsarctl clusters delete [flags]

Aliases: delete, delete

Common flags:
  -s, --admin-service-url string   The admin web service url that pulsarctl connects to. (default "http://localhost:8080")
  -C, --color string               toggle colorized logs (true,false,fabulous) (default "true")
  -h, --help                       help for this command
  -v, --verbose int                set log level, use 0 to silence, 4 for debugging (default 3)

Use 'pulsarctl clusters delete [command] --help' for more information about a command.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants