Add ns-isolation-policy commands for pulsarctl #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Contributor
Author
|
@sijie PTAL |
Contributor
Author
|
ping @sijie PTAL |
sijie
requested changes
Oct 18, 2019
pkg/ctl/nsisolationpolicy/broker.go
Outdated
| var examples []pulsar.Example | ||
| create := pulsar.Example{ | ||
| Desc: "Get broker with namespace-isolation policies attached to it", | ||
| Command: "pulsarctl ns-isolation-policy broker (cluster-name) --broker (broker address)", |
Member
There was a problem hiding this comment.
can we remove --broker to simplify it with ns-isolation-policy broker (cluster-name) (broker)?
Contributor
Author
There was a problem hiding this comment.
can we remove
--brokerto simplify it withns-isolation-policy broker (cluster-name) (broker)?
Sure, will fix it.
pkg/ctl/nsisolationpolicy/util.go
Outdated
| "strings" | ||
| ) | ||
|
|
||
| func convert(value string) (map[string]string, error) { |
Contributor
Author
There was a problem hiding this comment.
Yes, will move it to utils package.
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Contributor
Author
|
Done @sijie PTAL again, thanks. |
sijie
approved these changes
Oct 24, 2019
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
…l#88) Add `ns-isolation-policy` commands for pulsarctl - set - get - list - delete - brokers - broker
tisonkun
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Aug 16, 2023
…l#88) Add `ns-isolation-policy` commands for pulsarctl - set - get - list - delete - brokers - broker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com
Add
ns-isolation-policycommands for pulsarctl