Add auth provider for project #9
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
sijie
reviewed
Aug 28, 2019
Member
sijie
left a comment
sijie
left a comment
There was a problem hiding this comment.
@wolfstudy it seems that this auth provider is copied from pulsar-client-go. I can image how it can be used for pulsar client. but how does this work for pulsarctl (mainly pulsarctl is issuing http request)? Can you add the code to show how are you going to use this for securing the http requests?
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Contributor
Author
sijie
requested changes
Aug 28, 2019
Member
|
Also please add an integration test to ensure tls is working as expected |
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
zymap
reviewed
Aug 29, 2019
zymap
reviewed
Aug 29, 2019
zymap
reviewed
Aug 29, 2019
zymap
reviewed
Aug 29, 2019
zymap
reviewed
Aug 29, 2019
zymap
reviewed
Aug 29, 2019
zymap
reviewed
Aug 29, 2019
Member
|
@wolfstudy I left some questions. PTAL |
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #2
Motivation
Add auth provider for project
Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com