Skip to content

Conversation

@zymap
Copy link
Member

@zymap zymap commented Oct 17, 2019


Modifications

  • Add the token auth for the pulsarctl

---

*Modifications*

- Add the token auth for the pulsarctl
@zymap zymap requested review from sijie and wolfstudy October 17, 2019 06:10
@zymap zymap self-assigned this Oct 17, 2019
@sijie sijie mentioned this pull request Oct 17, 2019
29 tasks
)

func listClustersCmd(vc *cmdutils.VerbCmd) {
func ListClustersCmd(vc *cmdutils.VerbCmd) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you capitalize the first character?

Copy link
Member Author

@zymap zymap Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this command to validate the token worked. And the test in a different package.

Copy link
Contributor

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy
Copy link
Contributor

ping @sijie PTAL

@sijie sijie added this to the 0.0.1 milestone Oct 18, 2019
@sijie sijie merged commit 0115ba2 into master Oct 18, 2019
@sijie sijie deleted the token_auth branch October 18, 2019 06:41
tisonkun pushed a commit to tisonkun/pulsar-client-go that referenced this pull request Aug 15, 2023
*Modifications*

- Add the token auth for the pulsarctl
tisonkun pushed a commit to apache/pulsar-client-go that referenced this pull request Aug 16, 2023
*Modifications*

- Add the token auth for the pulsarctl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants