-
Notifications
You must be signed in to change notification settings - Fork 70
Provide the token auth #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
--- *Modifications* - Add the token auth for the pulsarctl
| ) | ||
|
|
||
| func listClustersCmd(vc *cmdutils.VerbCmd) { | ||
| func ListClustersCmd(vc *cmdutils.VerbCmd) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you capitalize the first character?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this command to validate the token worked. And the test in a different package.
wolfstudy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
|
ping @sijie PTAL |
*Modifications* - Add the token auth for the pulsarctl
*Modifications* - Add the token auth for the pulsarctl
Modifications