feat: changed to use transaction instead of managing sessions manually. And only when a transaction is needed#14
Merged
javierdelafuentesales merged 3 commits intomainfrom Feb 21, 2024
Conversation
javierdelafuentesales
changed the title
javierdelafuentesales
requested review from
MuFa117,
Xevi,
lee-hopin and
stephenarra
Xevi
approved these changes
Feb 21, 2024
fbaldi6
pushed a commit
that referenced
this pull request
Dec 16, 2024
…y. And only when a transaction is needed (#14) * feat: changed to use transaction only when needed * fix: prevent creating another transaction if there is one active * refactor: improve readability
fbaldi6
pushed a commit
that referenced
this pull request
Dec 16, 2024
…y. And only when a transaction is needed (#14) * feat: changed to use transaction only when needed * fix: prevent creating another transaction if there is one active * refactor: improve readability
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Stop opening sessions manually. Based on the spanner code, this should not be done.
https://github.com/googleapis/nodejs-spanner/blob/65f6a838be9f526cb2c1497c66345ef2949e35d4/src/session.ts#L77
Use
database.getTransactioninstead and only when a transaction is needed.We want to do this as we have realised that we are constantly creating and deleting sessions in spanner
We hope that this will improve the performance.