SC Not using NSI Term Data

[peternewman]

How to Reproduce
Add a shop and search for Plumb Centre or indeed seven-eleven, there are no suggestions

https://cdn.jsdelivr.net/npm/name-suggestion-index@7.0.20251101/dist/presets/nsi-id-presets.min.json

Contains:
"shop/trade/wolseley-8a4d16":{"name":"Wolseley","locationSet":{"include":["gb"]},"icon":"temaki-tools","geometry":["point","area"],"matchScore":2,"imageURL":"https://graph.facebook.com/WolseleyPlumbCentre/picture?type=large","terms":["parts center","parts centre","plumb center","plumb centre","wolseley","wolseley plumb & parts"],"tags":{"brand:wikidata":"Q8030423","shop":"trade"},"addTags":{"brand":"Wolseley","brand:wikidata":"Q8030423","name":"Wolseley","shop":"trade","trade":"plumbing"}}

westnordost/osmfeatures#29 and westnordost/osmfeatures@ad0263f imply term searching can work now, but trying to add a shop as Plumb Centre or indeed seven-eleven come up with no suggestions.

Expected Behavior
Suggest Wolseley/7-Eleven respectively.

Versions affected
SC v61.3

[paulklie]

seven-eleven, there are no suggestions

I can find "7-Eleven" in 62 beta 1.

[peternewman]

seven-eleven, there are no suggestions

I can find "7-Eleven" in 62 beta 1.

Yes, because that's the brand name, whereas you won't be able to find seven-eleven or 7-11 or just search for seven will show no results, all of which are matchNames which become terms:
https://nsi.guide/index.html?t=*&k=shop&v=convenience&tt=7-eleven

[westnordost]

osmfeatures doesn't search brand names by terms.

https://github.com/westnordost/osmfeatures/blob/f07b9c5743495d11fc36f705c69eeb4ecab54007/src/commonMain/kotlin/de/westnordost/osmfeatures/FeatureDictionary.kt#L257-L298

You can create a feature request at osmfeatures.

It would be helpful if you wrote what the iD behavior here is, as osmfeatures try to mirror the behavior of iD (read: order in which the results are shown). So, which precedence should searching brands by terms take?

[westnordost]

No, I am blind.

https://github.com/westnordost/osmfeatures/blob/f07b9c5743495d11fc36f705c69eeb4ecab54007/src/commonMain/kotlin/de/westnordost/osmfeatures/FeatureDictionary.kt#L282-L290

osmfeatures does search for terms of brands.

So this needs more investigation.

[peternewman]

It would be helpful if you wrote what the iD behavior here is, as osmfeatures try to mirror the behavior of iD (read: order in which the results are shown). So, which precedence should searching brands by terms take?

Having just checked, iD initially offers (with plumb ):

Which changes to (with plumb c):

And is just Wolseley and point by the time we get to plumb cen

osmfeatures does search for terms of brands.

The only real quirk (with both SC and iD is that they don't show the term too) which is fine IMHO for the presets (e.g. if I've typed in solicitor and can see Law Office, I understand they are synonyms, but I just have to take it on faith when I've asked for Plumb Centre and it's recommended Wolseley (which in this case I've also raised in NSI as osmlab/name-suggestion-index#11537 ).

That's reassuring, I thought I'd correctly checked (and linked to) where osmfeatures handles it, hence raising here not there.

[westnordost]

The only real quirk (with both SC and iD is that they don't show the term too) which is fine IMHO

Yes, I find this is fine, too. After all, these are terms. There is a separate field called aliases. Aliases are treated differently (they are shown).

[westnordost]

Investigation complete. As it turns out, the feature you mention was implemented on master, but there hasn't been any subsequent release of the library, haha:

westnordost/osmfeatures@v7.0...master