Skip to content

Conversation

@westnordost
Copy link
Member

respect preserveTags property in osmfeatures (fixes #6086, fixes #5985)

@westnordost westnordost requested a review from mnalis January 15, 2025 20:06
@mnalis
Copy link
Member

mnalis commented Jan 18, 2025

Um, what problems is it supposed to fix exactly? I've tried compiling that branch at bbf233d (at https://github.com/mnalis/StreetComplete/actions/runs/12810652342) and:

@mnalis
Copy link
Member

mnalis commented Jan 18, 2025

small_Screen_Recording_20250118_053045_StreetComplete.Dev.mp4

Or am I misunderstanding what is supposed to happen here? 🤷‍♂️

@westnordost
Copy link
Member Author

For it to work, a new version of the nsi-id-presets.json must be published which includes the preserveTags property in the data.

@westnordost
Copy link
Member Author

I just updated from the current NSI that includes the preserveTags. If you like, you could test again, @mnalis
(But I already tested the implementation, so I don't think it is required.)

@westnordost westnordost merged commit 01913d5 into master Feb 3, 2025
@FloEdelmann FloEdelmann deleted the preserveTags branch February 3, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

don't show the "There is no name sign" option in the places overlay when there is no input field for the name individual name for places of a brand

3 participants