Skip to content

Conversation

@westnordost
Copy link
Member

@westnordost westnordost commented May 26, 2025

fixes #6265

Turned out to be more involved.

Because previously, we didn't have the notion of aliases for surfaces (e.g. surface=earth == surface=dirt) like we had for building types.

This would lead to that when one would confirm the shown surface in a re-survey or overlay, let's say paving stones, and it was previously tagged as surface=bricks (considered an alias/subtype of this), then it would be re-tagged as surface=paving_stones. But we don't want that, we want it to stay bricks in this case.

So, I made this work like the aliases for BuildingType, and also made it consistent how both of these are implemented.

@westnordost westnordost requested a review from matkoniecz May 26, 2025 17:47
@westnordost
Copy link
Member Author

@matkoniecz a review by you would be highly appreciated, as you've been the person most involved with surface stuff

@aikencz
Copy link

aikencz commented Jun 4, 2025

I strongly disagree with removing of concrete:plates. I used this surface type relatively often (and correctly!). With the new version, it brings additional work to me. I have to add a note in StreetComplete and then set the correct surface in iD or JOSM.

@westnordost
Copy link
Member Author

Well, see here for my final opinion on it and why I agreed to remove it in the end:
#6265 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discourage tagging surface=concrete:plates, especially on footways

3 participants