Surface synonyms, remove concrete:plates as selectable surface #6290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6265
Turned out to be more involved.
Because previously, we didn't have the notion of aliases for surfaces (e.g.
surface=earth==surface=dirt) like we had for building types.This would lead to that when one would confirm the shown surface in a re-survey or overlay, let's say paving stones, and it was previously tagged as
surface=bricks(considered an alias/subtype of this), then it would be re-tagged assurface=paving_stones. But we don't want that, we want it to staybricksin this case.So, I made this work like the aliases for
BuildingType, and also made it consistent how both of these are implemented.