Fix angle normalization with non-zero startAt parameter #6307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normalize angles by shifting to origin first, then shifting back. Previous implementation failed for negative inputs with non-zero startAt.
Collaborator
|
This is the perfect change to add accompanying unit tests. |
Member
|
I agree with @riQQ |
Contributor
Author
|
Was about to add some :) |
Member
|
ah, cool! |
The test for isRightOf(p0, 270.0) now expects false instead of true, as a point lying exactly on the defined bearing should not be considered to the right of the line. This aligns the test with geometric convention, where "right of" excludes points that are collinear with the line.
Add unit tests for normalizeDegrees and normalizeRadians (Double/Float) to verify correct normalization with different startAt parameters and a variety of input values, including edge cases with negative numbers and offsets.
Contributor
Author
|
@westnordost ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation incorrectly normalized angles when using a non-zero startAt parameter. It would first normalize to [0, 360), then attempt to adjust for startAt, which failed for many cases, especially with negative input values.
The new implementation correctly handles all cases by:
This ensures the result is always in the range [startAt, startAt+360).
Example of the bug: normalizeDegrees(-720.0, 200.0) would return 0 instead of the correct value 360.