Skip to content

Conversation

@paulklie
Copy link
Collaborator

@paulklie paulklie commented Jun 17, 2025

Fixes #6346

@mnalis
Copy link
Member

mnalis commented Jun 17, 2025

FYI, I've changed the PR comment to use magic word Fixes #issuenumber (which will automatically close the issue as resolved if the PR is merged).

Have you tested if it works @paulklie ?

@matkoniecz matkoniecz added the feedback required more info is needed, issue will be likely closed if it is not provided label Jun 17, 2025
@paulklie
Copy link
Collaborator Author

FYI, I've changed the PR comment to use magic word Fixes #issuenumber (which will automatically close the issue as resolved if the PR is merged).

Have you tested if it works @paulklie ?

Thanks you. I have tested to see if a few charging stations around me would pop up correctly. I was not able to actually complete any since I do not know any charging stations where I have not already added the fee manually beforehand.

@matkoniecz
Copy link
Member

I was not able to actually complete any since I do not know any charging stations where I have not already added the fee manually beforehand.

you can disable automatic upload, fill fake data and press undo to both remove edit and check whether things got tagged correctly
then reenable automatic upload

@paulklie
Copy link
Collaborator Author

I was not able to actually complete any since I do not know any charging stations where I have not already added the fee manually beforehand.

you can disable automatic upload, fill fake data and press undo to both remove edit and check whether things got tagged correctly then reenable automatic upload

Great Idea, thanks!
Yes I tested, works fine!

@matkoniecz matkoniecz removed the feedback required more info is needed, issue will be likely closed if it is not provided label Jun 17, 2025
…s/general_fee/AddGeneralFee.kt

Co-authored-by: Mateusz Konieczny <matkoniecz@gmail.com>
Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if comments were added before the element filter, not in the middle of it (because that """ comment """ stuff is awkward)

@westnordost westnordost merged commit f1e6a0a into streetcomplete:master Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand GeneralFee Quest to bike chargers

5 participants