implemented isRelationIgnored, which does not ignore ferry routes #6387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westnordost
requested changes
Jul 5, 2025
Member
westnordost
left a comment
westnordost
left a comment
There was a problem hiding this comment.
should rename the parameter from ignoreRelationTypes to ignoreRelation, ignoreRelationWithTags or similar
Member
|
By the way, thanks for all your recent contributions so far! It's really quite a bunch! |
Collaborator
Author
Thanks! Really love this tool, so thought it was time to give back! |
westnordost
approved these changes
Jul 6, 2025
app/src/commonMain/kotlin/de/westnordost/streetcomplete/data/osm/mapdata/MapDataApiClient.kt
Outdated
Show resolved
Hide resolved
app/src/commonMain/kotlin/de/westnordost/streetcomplete/data/osm/mapdata/MapDataApiClient.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #6375 this function replaces the simple relationship filter and allows ferry routes to be processed while all other routes are still ignored.