Skip to content

Conversation

@paulklie
Copy link
Collaborator

@paulklie paulklie commented Jul 5, 2025

resolves #6385

@paulklie
Copy link
Collaborator Author

paulklie commented Jul 5, 2025

I was also thinking about renaming the quest to "AddCarChargingStationCapacity" to specifiy that it is only for cars. What do you think?

@mnalis
Copy link
Member

mnalis commented Jul 6, 2025

I was also thinking about renaming the quest to "AddCarChargingStationCapacity" to specifiy that it is only for cars. What do you think?

As that is what quest text says, it makes sense to me:

<string name="quest_charging_station_capacity_title">"How many cars can be charged here at the same time?"</string>

But that reminds me of another problem; what about e-trucks? Those are also covered by motor_vehicle... I'm not familiar if they use different charging connectors than e-cars or same? But probably either:

  • the filter should be changed to exclude trucks too (if connectors are not compatible), or
  • the text should be change to include trucks (if connectors are compatible)

@matkoniecz
Copy link
Member

Have you tested it? Based on source code it looks fine

@westnordost
Copy link
Member

Don't rename it, please, quests are saved in the database by name, each rename would require to write an upgrade-step for the database. Not worth it.q

Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested it? Based on source code it looks fine

He didn't, because I can see that based on the source code, it doesn't look fine :-P

@westnordost westnordost merged commit ee04b58 into streetcomplete:master Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

charging capacity quest mishandles non car chargers.

4 participants