Align highlighted elements for board type quests #6420
Conversation
|
|
||
| override fun getHighlightedElements(element: Element, getMapData: () -> MapDataWithGeometry) = | ||
| getMapData().filter("nodes with tourism = information and information = board") | ||
| getMapData().filter("nodes with tourism = information") |
There was a problem hiding this comment.
Interestingly, the board type quest only triggers on nodes (see elementFilter above), while the board title quest also includes ways and relations. I mirrored this for the highlighting (don't include ways+rels here in the highlighting filter as was done for the board title quest).
Should this be aligned as well? Its probably of low consequence, since information=boards are almost exclusively nodes (about 1 in 400 is a way).
There was a problem hiding this comment.
Aligning them makes sense, my instinct would be to treat way ones as tagging mistakes or nanomapping reaching parody levels
but investigating them to check is this guess true would make sense
|
I see it was tested and seems to make sense to me I looked at file history including earlier name and #5882 and it does not seem discussed/changed so far |
|
And thanks for a PR! |
…urist information offices (reverts #6420)
2 participants
Summary
I noticed that the set of highlighted elements for the two board type quests (name and type) was different, which could be confusing when the quests trigger on the same (or nearby) elements. This PR aligns both by expanding the set of highlighted elements for the board type quest. This is a follow-up on #6418.
Screenshot
https://www.openstreetmap.org/node/9199014037#map=19/50.705403/10.695204