-
-
Notifications
You must be signed in to change notification settings - Fork 397
added quests to observation tower #6430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added quests to observation tower #6430
Conversation
|
I think this is okay. The hint text for WheelchairAccessBusiness is certainly less well fitting ;-) |
westnordost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, are there nodes with highway=steps? Seems wrong to me, I think it would be more clear if there were two filters.
Sure, though there are less than 3k |
|
Oh, that's weird. What is this supposed to be? Or is it a tagging error? The wiki doesn't mention it at all. |
There has been some discussion on this topic (https://wiki.openstreetmap.org/wiki/Talk:Tag:highway%3Dsteps#nodes), and I think I agree that tagging ladders and single steps like this could be reasonable. Though I guess we could also ask the step question for these nodes right? |
|
hm yeah, I guess we could |
app/src/androidMain/kotlin/de/westnordost/streetcomplete/quests/step_count/AddStepCount.kt
Show resolved
Hide resolved
|
Due to the query of the Opening Times quest, users will not be asked for the opening times of towers without a name. I don't think this is to big of an issue. |
app/src/androidMain/kotlin/de/westnordost/streetcomplete/quests/step_count/AddStepCount.kt
Show resolved
Hide resolved
2 spaces, inner () is not necessary but ok, for clarity
|
See https://community.openstreetmap.org/t/reporting-streetcomplete-issues/135672/3 - it looks like that there are tags that should cause this quest to be excluded for towers. |
Thanks for the pointer, as mentioned in the thread I will submit a patch. |

fixes #6427