First aid kit quest

[NicodeH]

Discussion : #6457
Adding first aid kit quest

[HolgerJeromin]

This has parts of #6538 and many more commits which do not belong here

[paulklie]

Nice work so far!

[paulklie]

The implementation looks good. I think others might be better at giving feedback for the icon which I suspect might need some more work.

[paulklie]

Also if your icon is approved you should add it and your name to https://github.com/streetcomplete/StreetComplete/blob/master/res/graphics/authors.txt

[westnordost]

Hmm, has it been discussed whether it would be better to make the AddDefibrillatorLocation quest generic enough that it can be asked for other things, too, as it is otherwise a complete duplicate of that quest? Otherwise, we might quickly end up with an array of quests like these, which each need

• an own icon
• an own title
• about 40 lines of code

To generalize the AddDefibrillatorLocation quest instead, we'd need to

• find a more generic icon
• more generic title
• change logic in getHighlightedElements() to only highlight the exact same feature
• rename quest and form, rename quest also in database via DatabaseInitializer.kt once, add alias for the old name in EditTypeAliasesModule.kt so that the old quest also appears correctly in statistics

but only once, of course.

---

On the other hand, having had a look at taginfo, the *:location key is currently not used (in that way) for any other map feature than the defibrillator. Even first_aid_kit:location is basically unused now. Was this tag discussed in the community? It is also not mentioned in the wiki.
Anyhow, my point is that there may be more things for which it is currently not tagged with a description where they are. I don't know, are there? Can anyone come up with more things that could use a precise location description?

---

Independent of the above, does the AddDefibrillatorLocation (and then subsequently the AddFirstAidKit) even appear at all with the current filtering?

Both filter out any objects with location already tagged. Doesn't the quest that asks whether the amenity is indoor add exactly this tag (location=indoor/outdoor)?

[paulklie]

Both filter out any objects with location already tagged. Doesn't the quest that asks whether the amenity is indoor add exactly this tag (location=indoor/outdoor)?

No, it adds indoor=yes/no :

StreetComplete/app/src/androidMain/kotlin/de/westnordost/streetcomplete/quests/amenity_indoor/AddIsAmenityIndoor.kt

Lines 109 to 111 in aa9d722

	IsAmenityIndoorAnswer.INDOOR -> tags["indoor"] = "yes"
	IsAmenityIndoorAnswer.OUTDOOR -> tags["indoor"] = "no"
	IsAmenityIndoorAnswer.COVERED -> tags["covered"] = "yes"

[paulklie]

On the other hand, having had a look at taginfo, the *:location key is currently not used (in that way) for any other map feature than the defibrillator.
Anyhow, my point is that there may be more things for which it is currently not tagged with a description where they are. I don't know, are there? Can anyone come up with more things that could use a precise location description?

I see quite a bit of usage for:

• firehydrants
• changing tables.
• Post boxes

Other than being useful, I feel like asking the location of an object should be done only if the following apply:

1. The object should not be to common. The free text location quest is one of the most time consuming quests in the app, asking for to many objects wastes users time. for example the over 2 million fire hydrants would quickly overload this app.
2. The object should be easily accessible. Changing tables, for example, would require surveying every toilet. In countries with gendered toilets this can be illegal. Also this might require paying a fee.
3. The object should be in a complex, ideally indoor, environment: It does not make scene to ask for objects placed outdoors where their location will be obvious from its coordinates. since a description adds little additional information. For example, many post boxes are outdoors and especially in rural settings asking for them will quickly become very tedious.

I cannot think of any other objects that fulfill these requirements, other than the AED and first aid kit.

Even first_aid_kit:location is basically unused now. Was this tag discussed in the community? It is also not mentioned in the wiki.

I have not found any such discussion, however I would argue that since an first aid kit is very similar to a defibrillator, both in purpose and placement, that this tag makes a lot of sense here.

[westnordost]

For fire hydrants, changing tables and post boxes, the key seems to be used in a different way, however. Look at the values. It's not a free-text description but some pre-defined values for e.g. changing tables, for post boxes it is some address and for fire hydrants it's mostly just the road... which doesn't make much sense.

[westnordost]

Okay, I take from the earlier comment that other than defibrillators and first aid kits, there's probably not going to be anything else that should be asked for like this. So, let's leave this quest as-is.

I might also change the icon a little after merge.

[westnordost]

I made the icon more similar to the defibrillator icon and better visible when displayed at a small size.