Skip to content

suite: recover and fail on subtest#1455

Closed
anuragprafulla wants to merge 1 commit into
stretchr:masterfrom
anuragprafulla:recover-and-fail-for-subtest
Closed

suite: recover and fail on subtest#1455
anuragprafulla wants to merge 1 commit into
stretchr:masterfrom
anuragprafulla:recover-and-fail-for-subtest

Conversation

@anuragprafulla
Copy link
Copy Markdown

Summary

Changes

Motivation

Related issues

@dolmen
Copy link
Copy Markdown
Collaborator

dolmen commented Aug 11, 2023

Please spare the time of the maintainers by filling the description properly. If contributing in English is an issue, please at least tell that.

Also:

  • please provide an example of failure running on go.dev/play. Here is a template: https://go.dev/play/p/fjdBPM9UkcV
  • in your branch add a testcase that will serve for regression testing

@dolmen dolmen added bug pkg-suite Change related to package testify/suite labels Aug 11, 2023
@dolmen dolmen changed the title Recover and fail on subtest suite: recover and fail on subtest Aug 11, 2023
Comment thread suite/suite.go
}()

return oldT.Run(name, func(t *testing.T) {
defer recoverAndFailOnPanic(t)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change needs a matching test case for future regression testing.

@xwjdsh
Copy link
Copy Markdown

xwjdsh commented Aug 24, 2023

@dolmen I submitted a PR long ago and was just reminded by a reply. I noticed this PR was duplicated with it, could you please take a look #1293?

@dolmen
Copy link
Copy Markdown
Collaborator

dolmen commented Oct 16, 2023

@xwjdsh There are changes in #1471 which are about to be merged and are also related to suite subtests. Could you add your review there and tell me if there will be something remaining to fix in #1455 and #1293?

@dolmen
Copy link
Copy Markdown
Collaborator

dolmen commented Oct 30, 2023

Closing because this change is included in #1471.

@dolmen dolmen closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug pkg-suite Change related to package testify/suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants