assert: add position and pass msg to underlying func in InDeltaMapValues, InDeltaMapValues, and InEpsilonSlice#1514
Open
hendrywiranto wants to merge 2 commits into
Open
assert: add position and pass msg to underlying func in InDeltaMapValues, InDeltaMapValues, and InEpsilonSlice#1514hendrywiranto wants to merge 2 commits into
hendrywiranto wants to merge 2 commits into
Conversation
hendrywiranto
force-pushed
the
pass-msg
branch
4 times, most recently
from
e073c9f to
0cd093d
Compare
hendrywiranto
force-pushed
the
pass-msg
branch
2 times, most recently
from
a44a1b8 to
fcc8dfd
Compare
hendrywiranto
force-pushed
the
pass-msg
branch
from
fcc8dfd to
caa15c3
Compare
dolmen
added
pkg-assert
dolmen
requested changes
May 16, 2024
| // appendMsgAndArgs appends a message string to the first element of the msgAndArgs slice | ||
| // and returns the updated slice. | ||
| func appendMsgAndArgs(msgAndArgs []interface{}, message string) []interface{} { | ||
| if len(msgAndArgs) == 0 || msgAndArgs == nil { |
Collaborator
There was a problem hiding this comment.
Check of msgAndArgs == nil is redundant. This is dead code.
Contributor
Author
There was a problem hiding this comment.
removed, thanks!
| } | ||
|
|
||
| return msgAndArgs | ||
| } |
Collaborator
There was a problem hiding this comment.
Refactor the function body to use a switch on len(msgAndArgs) instead of multiple if.
Contributor
Author
There was a problem hiding this comment.
thank you for the review, I have adjusted the function to use switch
dolmen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add position and pass msg to underlying func in
InDeltaSlice,InDeltaMapValues, andInEpsilonSliceChanges
msgAndArgsslice in those 3 funcsat index:for slice indexat key:for map keyMotivation
When using those 3 functions, users don't know which key/index of the map/slice that produces the error because currently it's not added into the
msgAndArgsslice.Example
InDeltaSliceBefore
After
InDeltaMapValuesBefore
After
InEpsilonSliceBefore
After
