Replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml#1725
Conversation
|
While I get the point, removing support for old Go versions is something that should be stated by maintainer @dolmen @brackendawson |
|
Another PR was opened to address this apparently The kubernetes' yaml version doesn't imply to bump Go minimal version |
|
I also considered the Kubernetes yaml fork, but this one still has the 8 year old |
|
The tests are failing. I would say let's wait for a go/no-go from @dolmen or @brackendawson to bump minimal Go version for testify. I don't feel like there is an urge in fixing tests if your PR is declined because of the minimal Go version bump. |
|
There is a major downside in any replacement: I expect that the new library doesn't have 100% identical behavior. Instead replacement driven by the end user is already supported and documented: see package |
|
Please note there is also https://github.com/yaml/go-yaml/ in preparation It's a fork of gopkg.in/yaml made by the official YAML team |
|
Given the discussion in #1724 I'm quite confident that we won't be moving to github.com/goccy/go-yaml |
Summary
Replace
gopkg.in/yamlwithgithub.com/goccy/go-yaml. See #1724.This was previously attempted in #1120, but the PR got closed due to
go-yamlhaving a high number of dependencies. This has since been resolved.go-yamldoes not have any dependencies anymore.The only downside is that
go-yamlrequires at least golang v1.21