chore: improve tests for True and False asserters.#1744
Closed
ccoVeille wants to merge 1 commit into
Closed
Conversation
Only the tests are updated, code is unchanged. Previously, the tests were checking only the result of the asserter. Using captureTestingT helper allows to check the error message
ccoVeille
force-pushed
the
improve-tests-true-false
branch
from
ab19c8c to
f5fed19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We are now testing the failure messages for the assert package.
Changes
Only the tests are updated, code is unchanged.
Using captureTestingT helper helps us to check:
Previously the tests were checking only the result of the asserter, but not the error message.
Motivation
It allows us to make sure the error message reported are OK.
Here I'm limiting the scope to show how it could help us.
Related issues
This is a proof of concept PR that follows up #1737 that was closed because:
it was not using a fork
there were a lot of changes to review.
chore: improve tests #1737