suite: prevent panic when SetupTest skips with HandleStats#1877
Merged
dolmen merged 1 commit intoMay 11, 2026
Conversation
dolmen
changed the title
dolmen
force-pushed
the
fix/suite-skip-stats-panic
branch
from
df6e494 to
52a4271
Compare
dolmen
approved these changes
May 7, 2026
Collaborator
|
@blackwell-systems Please fix the commit message to replace "fix(suite): prevent panic" with "suite: fix panic" |
blackwell-systems
force-pushed
the
fix/suite-skip-stats-panic
branch
from
52a4271 to
636bacf
Compare
dolmen
approved these changes
May 11, 2026
dolmen
force-pushed
the
fix/suite-skip-stats-panic
branch
from
636bacf to
fdc6894
Compare
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a suite implements
HandleStats(theWithStatsinterface) andSetupTest()callst.Skip(), the suite panics with a nil pointer dereference. This is a bug, not expected behavior.The bug
stats.start()was registered afterSetupTest()in the test runner. WhenSetupTest()callst.Skip(), Go'sruntime.Goexit()fires, skippingstats.start()entirely. The deferredstats.end()then accessess.TestStats[testName]which is nil becausestart()never created the map entry.The fix
Move
stats.start()beforeSetupTest()so theTestStatsentry always exists whenend()runs, regardless of whether setup skips, fails, or panics. This also makes timing more accurate since setup duration is now included.One line moved, one test added. All 8 packages pass.
Fixes #1722