feat(fixtures): accept multiple fixture files (closes #910)#1590
Open
0xdeadd wants to merge 1 commit into
Open
feat(fixtures): accept multiple fixture files (closes #910)#15900xdeadd wants to merge 1 commit into
0xdeadd wants to merge 1 commit into
Conversation
The fixtures command previously required exactly one file argument. This extends it to accept one or more files, executed sequentially in the order given. Closes stripe#910. UpdateEnv is called after each fixture so later files can reference vars produced by earlier ones via ${.env:VAR}. Execution aborts on the first error to preserve the established single-file behavior and surface failures immediately. Adds a MinimumNArgs validator mirroring the existing MaximumNArgs, with tests, since the validators package only had Exact and Maximum variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #910.
The
fixturescommand previously required exactly one file argument. This extends it to accept one or more files, executed sequentially in the order given.Behavior
UpdateEnvis called after each fixture, so later files can reference vars produced by earlier ones via${.env:VAR}.Implementation
MinimumNArgsvalidator topkg/validators/cmds.go, mirroring the existingMaximumNArgs, since the package only hadExactandMaximumvariants. Includes tests.fixturescommand fromvalidators.ExactArgs(1)tovalidators.MinimumNArgs(1)and wrapped the runner body in a per-file loop.UseandLongto reflect the new shape.Test
gofmtandgo vetclean.