Fix failing tests #360
Merged
Fix failing tests #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimks
requested review from
bajtos,
hacksparrow,
jannyHou and
rashmihunt
as code owners
dhmlau
approved these changes
Jul 24, 2018
jannyHou
approved these changes
Jul 26, 2018
Contributor
jannyHou
left a comment
jannyHou
left a comment
There was a problem hiding this comment.
👍 LGTM
loopback-cli fails since the msg of lb --help changed, should be fixed by updating the help file in https://github.com/strongloop/loopback-cli/tree/master/test/fixtures accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #354
Please take a look at just the first commit; the second is linting and eslint dependency upgrades
Related issues
Checklist
guide