Skip to content

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Sep 1, 2016

A follow-up for strongloop/strong-remoting#343, which dropped Dynamic and related APIs.

@gunjpan please review
cc @richardpringle

Requires strongloop/strong-remoting#343

Connect to strongloop-internal/scrum-loopback#974
Connect to strongloop-internal/scrum-loopback#885

TODO before merging

@bajtos
Copy link
Member Author

bajtos commented Sep 1, 2016

CI builds are failing because npm installs wrong version of strong-remoting. They should start passing once strongloop/strong-remoting#343 is landed.

@Amir-61
Copy link
Member

Amir-61 commented Sep 9, 2016

@bajtos

CI builds are failing because npm installs wrong version of strong-remoting. They should start passing once strongloop/strong-remoting#343 is landed.

I'm trying this PR with NPM link to your branch in strongloop/strong-remoting#343 and it gives me the following error:

> Mocha exploded!
>> Error: RemoteObjects.convert(name, fn) is no longer supported. Use remoteObjects.defineType(name, converter) instead.
>>   at Function.RemoteObjects.convert.RemoteObjects.convert [as convert] (/Users/jafaria/workspace/strong-remoting/lib/remote-objects.js:796:9)
>>   at Function.Model.setup (/Users/jafaria/workspace/loopback-connector-remote/node_modules/loopback/lib/model.js:138:19)
>>   at module.exports (/Users/jafaria/workspace/loopback-connector-remote/node_modules/loopback/lib/model.js:857:9)
>>   at new Registry (/Users/jafaria/workspace/loopback-connector-remote/node_modules/loopback/lib/registry.js:26:21)
>>   at Object.<anonymous> (/Users/jafaria/workspace/loopback-connector-remote/node_modules/loopback/lib/loopback.js:49:21)
>>   at Module._compile (module.js:410:26)
>>   at Object.Module._extensions..js (module.js:417:10)
>>   at Module.load (/Users/jafaria/workspace/loopback-connector-remote/node_modules/grunt/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
>>   at Function.Module._load (module.js:301:12)
>>   at Module.require (module.js:354:17)
>>   at require (internal/module.js:12:17)
>>   at Object.<anonymous> (/Users/jafaria/workspace/loopback-connector-remote/node_modules/loopback/index.js:13:33)
>>   at Module._compile (module.js:410:26)
>>   at Object.Module._extensions..js (module.js:417:10)
>>   at Module.load (/Users/jafaria/workspace/loopback-connector-remote/node_modules/grunt/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
>>   at Function.Module._load (module.js:301:12)
>>   at Module.require (module.js:354:17)
>>   at require (internal/module.js:12:17)
>>   at Object.<anonymous> (/Users/jafaria/workspace/loopback-connector-remote/test/helper.js:9:16)
>>   at Module._compile (module.js:410:26)
>>   at Object.Module._extensions..js (module.js:417:10)
>>   at Module.load (/Users/jafaria/workspace/loopback-connector-remote/node_modules/grunt/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
>>   at Function.Module._load (module.js:301:12)
>>   at Module.require (module.js:354:17)
>>   at require (internal/module.js:12:17)
>>   at /Users/jafaria/workspace/loopback-connector-remote/node_modules/mocha/lib/mocha.js:220:27
>>   at Array.forEach (native)
>>   at Mocha.loadFiles (/Users/jafaria/workspace/loopback-connector-remote/node_modules/mocha/lib/mocha.js:217:14)
>>   at MochaWrapper.run (/Users/jafaria/workspace/loopback-connector-remote/node_modules/grunt-mocha-test/tasks/lib/MochaWrapper.js:51:15)
>>   at /Users/jafaria/workspace/loopback-connector-remote/node_modules/grunt-mocha-test/tasks/mocha-test.js:86:20
>>   at capture (/Users/jafaria/workspace/loopback-connector-remote/node_modules/grunt-mocha-test/tasks/mocha-test.js:33:5)
>>   at Object.<anonymous> (/Users/jafaria/workspace/loopback-connector-remote/node_modules/grunt-mocha-test/tasks/mocha-test.js:81:5)
>>   at Object.<anonymous> (/Users/jafaria/workspace/loopback-connector-remote/node_modules/grunt/lib/grunt/task.js:255:15)
>>   at Object.thisTask.fn (/Users/jafaria/workspace/loopback-connector-remote/node_modules/grunt/lib/grunt/task.js:73:16)
>>   at Object.<anonymous> (/Users/jafaria/workspace/loopback-connector-remote/node_modules/grunt/lib/util/task.js:294:30)
>>   at Task.runTaskFn (/Users/jafaria/workspace/loopback-connector-remote/node_modules/grunt/lib/util/task.js:244:24)
>>   at Task.<anonymous> (/Users/jafaria/workspace/loopback-connector-remote/node_modules/grunt/lib/util/task.js:293:12)
>>   at /Users/jafaria/workspace/loopback-connector-remote/node_modules/grunt/lib/util/task.js:220:11
>>   at nextTickCallbackWith0Args (node.js:419:9)
>>   at process._tickDomainCallback (node.js:389:13)
>>   at Function.Module.runMain (module.js:444:11)
>>   at startup (node.js:136:18)
>>   at node.js:966:3

Could you please run npm test locally to see if you get the same failure?

@bajtos
Copy link
Member Author

bajtos commented Sep 9, 2016

Will do.

Note that the error is thrown by code in node_modules/loopback/lib/model.js, you need a newer version of loopback (strongloop/loopback#2696) too.

Circular dependencies are not fun :(

@bajtos bajtos force-pushed the feature/coercion-overhaul branch from f1cf3ae to b82bd1a Compare September 9, 2016 07:08
@bajtos bajtos force-pushed the feature/coercion-overhaul branch from b82bd1a to bce9971 Compare September 9, 2016 07:51
@bajtos bajtos merged commit a009404 into master Sep 9, 2016
@bajtos bajtos deleted the feature/coercion-overhaul branch September 9, 2016 08:00
@bajtos bajtos removed the #review label Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants