Skip to content

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Mar 26, 2015

Require individual methods like classify instead of the whole module. This reduces the size of underscore.string browser bundle from ~27kb down to ~2kb.

See #989

/to @ritch please review

Require individual methods like `classify` instead of the whole module.
This reduces the size of the browser bundle from ~27kb down to ~2kb.
@ritch
Copy link
Member

ritch commented Mar 26, 2015

Cool!

LGTM

@ritch ritch assigned bajtos and unassigned ritch Mar 26, 2015
bajtos added a commit that referenced this pull request Mar 27, 2015
Import subset of underscore.string scripts only
@bajtos bajtos merged commit ade5d5e into master Mar 27, 2015
@bajtos bajtos removed the #review label Mar 27, 2015
@bajtos bajtos deleted the fix/browser-bundle-size branch March 27, 2015 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants