Skip to content

Conversation

@justinwatkins
Copy link

Passing the options through to the event handler allows for far more flexibility. Since getCurrentContext is on it's way out and currently acting more strangely than usual, this is a good alternative I think.

@slnode
Copy link

slnode commented Jul 20, 2016

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@slnode
Copy link

slnode commented Jul 20, 2016

Can one of the admins verify this patch?

3 similar comments
@slnode
Copy link

slnode commented Jul 20, 2016

Can one of the admins verify this patch?

@slnode
Copy link

slnode commented Jul 20, 2016

Can one of the admins verify this patch?

@slnode
Copy link

slnode commented Jul 20, 2016

Can one of the admins verify this patch?

@davidcheung
Copy link
Contributor

ok to test
related to #2521

@yotamsha
Copy link

I need this as well..

@davidcheung
Copy link
Contributor

@justinwatkins thanks for your contribution! Would you be able to add a unit test as well, then we can avoid regression of this feature down the line, and add it to master branch as well

@justinwatkins
Copy link
Author

Yes, I will add a unit test as well.

@davidcheung davidcheung self-assigned this Aug 22, 2016
@davidcheung
Copy link
Contributor

which ever lands first can close #1628 as well

@loay
Copy link
Contributor

loay commented Oct 13, 2016

Hi @justinwatkins please mention @davidcheung and @loay after you commit the unit test. Thanks.

@bajtos
Copy link
Member

bajtos commented Nov 10, 2016

Also please improve the commit message - describe the change in more detail, follow our guidelines for commit messages.

@bajtos
Copy link
Member

bajtos commented Dec 8, 2016

Closing in favour of #2992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants