Allow password reset request for users in realms (v3.x) #2998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
2 tasks
beeman
force-pushed
the
bb/password-reset-realms-3.x
branch
from
ebde81e to
a011147
Compare
Contributor
|
@slnode okay to test |
beeman
force-pushed
the
bb/password-reset-realms-3.x
branch
from
a011147 to
24e6e12
Compare
Contributor
Author
|
I'll rebase this on master once #2992 lands as it touches the code in the sample places. |
Member
beeman
force-pushed
the
bb/password-reset-realms-3.x
branch
from
24e6e12 to
cddfb9c
Compare
Contributor
Author
|
@bajtos done :) |
Member
|
@slnode ok to test |
Contributor
|
looks like dependant strong-nginx-controller — Failed! (cddfb9c) [sl-ci-run INFO 114.27 ]: Stripping ANSI escape codes from tests.tap...
[sl-ci-run INFO 114.39 ]: Tests passed.
[sl-ci-run INFO 114.39 ]: *************** BUILD FRAMEWORK REPORT CARD ****************
[sl-ci-run INFO 114.39 ]: ** Sanity checks : pass [required]
[sl-ci-run INFO 114.39 ]: ** Install dependencies : pass [required]
[sl-ci-run INFO 114.39 ]: ** Linter : pass [optional]
[sl-ci-run INFO 114.39 ]: ** Generate artifacts : pass [required]
[sl-ci-run INFO 114.39 ]: ** Run tests : pass [required]
[sl-ci-run INFO 114.39 ]: ** Coverage report : pass [optional]
[sl-ci-run INFO 114.39 ]: *************** BUILD FRAMEWORK REPORT CARD ****************
[89d66e82] $ rm -rf $BUILD_FRAMEWORK_ROOT $BUILD_FRAMEWORK_TMPDIR
Set build name.
New build name is '#2672 (origin/master)'
Variable with name 'BUILD_DISPLAY_NAME' already exists, current value: '#2672 (origin/master)', new value: '#2672 (origin/master)'
[PostBuildScript] - Execution post build scripts.
[89d66e82] $ rm -rf $BUILD_FRAMEWORK_ROOT $BUILD_FRAMEWORK_TMPDIR
Archiving artifacts
[Cobertura] Publishing Cobertura coverage report...
Publishing Cobertura coverage results...
Cobertura coverage report found.
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing JUnit
[xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern '**/*xunit.xml' relative to '/mnt/jenkins/workspace/strong-nginx-controller/89d66e82' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'?
[xUnit] [WARNING] - No test reports found for the metric 'JUnit' with the resolved pattern '**/*xunit.xml'.
[xUnit] [INFO] - Skipping the metric tool processing.
[xUnit] [INFO] - There are errors when processing test results.
[xUnit] [INFO] - Skipping tests recording.
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.tap,*/*.tap
Saving reports...
Processing '/var/lib/jenkins/jobs/strong-nginx-controller/configurations/axis-label/amazon-0.10/builds/2672/tap-master-files/tests.tap'
Parsing TAP test result [/var/lib/jenkins/jobs/strong-nginx-controller/configurations/axis-label/amazon-0.10/builds/2672/tap-master-files/tests.tap].
TAP Reports Processing: FINISH
[Set GitHub commit status (universal)] SUCCESS on repos [GHRepository@3525cebf[description=Nginx controller for Arc,homepage=,name=strong-nginx-controller,license=<null>,fork=false,size=82,milestones={},language=JavaScript,commits={},source=<null>,parent=<null>,url=https://api.github.com/repos/strongloop/strong-nginx-controller,id=29508328]] (sha:c4becda) with context:strong-nginx-controller/label=amazon-0.10
Setting commit status on GitHub for https://github.com/strongloop/strong-nginx-controller/commit/c4becda4f9687225925b3b013eac9231072037c9
ERROR: [GitHub Commit Status Setter] - {"message":"Validation Failed","errors":[{"resource":"Status","code":"custom","message":"This SHA and context has reached the maximum number of statuses."}],"documentation_url":"https://developer.github.com/v3/repos/statuses/#create-a-status"}, setting build result to FAILURE
Build step 'Set build status on GitHub commit [deprecated]' changed build result to FAILURE |
Contributor
|
@slnode test please |
|
I need this merge please |
Contributor
|
connector-soap and swagger seems to never pass on |
|
When it will be updated in npm repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the User.resetPassword method only accepts an email address as a parameter.
When you have a LoopBack application that partitions the users in Realms you need to find the user based on it's email address + realm, because it allows for 2 users with the same email address.
This PR fixes the issue by adding support for an optional realm property, that will enhance the filter used in the findOne method.
Related issues
The issue fixed in this PR
#2866
PR for v2.x:
#2980
Checklist