Skip to content

Conversation

@davidcheung
Copy link
Contributor

@davidcheung davidcheung commented Dec 6, 2016

DO NOT MERGE, using PR to test if ignore downstream worked
related to #3000

@davidcheung davidcheung force-pushed the opt-out-broken-downstream-2.x.2 branch from 51f47ee to 75af809 Compare December 6, 2016 19:13
@davidcheung davidcheung self-assigned this Dec 6, 2016
@davidcheung
Copy link
Contributor Author

this did not work, perhaps a759286 needs to be merged into master for Jenkins to pick it up
cc @pthieu @superkhau

@superkhau
Copy link
Contributor

@davidcheung Yes, I believe that has to be merged into master for it to work. @rmg Can you chime in here? @davidcheung is trying to get downstream ignores to work on the 2.x branch. Is it not good enough to modify the package.json on the 2.x branch?

@rmg
Copy link
Member

rmg commented Dec 7, 2016

It has to be merged into the destination branch. Each monitored branch is a separate project.

@davidcheung
Copy link
Contributor Author

@rmg the commit is already merged into destination branch (2.x) a759286
is the package.json name the correct name to use?
as the jenkins job shows it with the branch name like dashboard-controller~master vs dashboard-controller

@rmg
Copy link
Member

rmg commented Dec 7, 2016

@davidcheung the package.json is correct, but the repo scanner was disabled for the last few days due to a plugin rollback. I fixed it earlier today and the jobs were regenerated about 90 minutes ago. Rebasing this PR should do the correct thing now.

@pthieu pthieu self-requested a review December 7, 2016 23:17
package.json Outdated
"downstreamIgnoreList" : [
"dashboard-controller",
"gateway-director-management-interface"
"gateway-director-management-interface",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing new GH review

@pthieu pthieu requested review from pthieu and removed request for pthieu December 7, 2016 23:38
@bajtos bajtos changed the title DO NOT MERGE [DO NOT MERGE] test downstream CI ignores Dec 8, 2016
@davidcheung
Copy link
Contributor Author

@slnode test please

@davidcheung
Copy link
Contributor Author

Looks like it still doesnt ignore,

  • [cis-jenkins] downstream: dashboard-controller@develop — Failed! (e9d7396)
  • [cis-jenkins] downstream: gateway-director-management-interface@master — Failed! (e9d7396)

@davidcheung davidcheung force-pushed the opt-out-broken-downstream-2.x.2 branch from e9d7396 to 5b7b8f9 Compare January 3, 2017 18:21
@rmg
Copy link
Member

rmg commented Jan 3, 2017

The ignore list was added incorrectly so it is not actually being used. See #3000 (comment)

@davidcheung davidcheung force-pushed the opt-out-broken-downstream-2.x.2 branch from 5b7b8f9 to 7a7a1af Compare January 3, 2017 22:19
@davidcheung
Copy link
Contributor Author

@slnode test please
looks like some network issue https://cis-jenkins.swg-devops.com/job/npr/job/loopback~2.x/165/
trying again, then should work and can close.

@davidcheung
Copy link
Contributor Author

test success, closing

@davidcheung davidcheung closed this Jan 4, 2017
@davidcheung davidcheung deleted the opt-out-broken-downstream-2.x.2 branch January 4, 2017 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants