-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[DO NOT MERGE] test downstream CI ignores #3006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
51f47ee to
75af809
Compare
|
this did not work, perhaps a759286 needs to be merged into master for Jenkins to pick it up |
|
@davidcheung Yes, I believe that has to be merged into master for it to work. @rmg Can you chime in here? @davidcheung is trying to get downstream ignores to work on the 2.x branch. Is it not good enough to modify the package.json on the 2.x branch? |
|
It has to be merged into the destination branch. Each monitored branch is a separate project. |
|
@davidcheung the |
package.json
Outdated
| "downstreamIgnoreList" : [ | ||
| "dashboard-controller", | ||
| "gateway-director-management-interface" | ||
| "gateway-director-management-interface", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing new GH review
|
@slnode test please |
e9d7396 to
5b7b8f9
Compare
|
The ignore list was added incorrectly so it is not actually being used. See #3000 (comment) |
5b7b8f9 to
7a7a1af
Compare
|
@slnode test please |
|
test success, closing |
DO NOT MERGE, using PR to test if ignore downstream worked
related to #3000