Invalidate AccessTokens on password change #3018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Many of the changes in the test file are whitespace-only, see https://github.com/strongloop/loopback/pull/3018/files?w=1 |
loay
approved these changes
Dec 9, 2016
Contributor
|
@slnode test please |
1 similar comment
Contributor
|
@slnode test please |
raymondfeng
reviewed
Dec 9, 2016
common/models/user.js
Outdated
| }; | ||
|
|
||
| User._invalidateAccessTokensOfUsers = function(userIds, cb) { | ||
| if (!userIds.length) return cb(); |
Member
There was a problem hiding this comment.
Should we check with !Array.isArray(userIds) || !userIds.length?
I think we need to use process.nextTick to cb() too.
Invalidate all existing sessions (delete all access tokens) after user's password was changed.
bajtos
force-pushed
the
fix/session-expiry2
branch
from
062c529 to
29a17f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalidate all existing sessions (delete all access tokens) after user's password was changed.
This patch supersedes #2665
Connect to strongloop-internal/scrum-loopback#925
@loay @raymondfeng PTAL