Fix role check in apps with multiple user models #3835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2018
|
LGTM. |
raymondfeng
approved these changes
Mar 20, 2018
|
@bajtos I did not get any notification for CLA. Can this be done now? |
Member
Author
|
@akki-ng the commit was authored by myself only, that's why no CLA check was triggered for you. We will deal with CLA in the other pull request you have sent yourself. For reference, this is the URL where you can sign: https://cla.strongloop.com/agreements/strongloop/loopback |
|
@bajtos Cool. Thanks for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug where the access context was created with incorrect principal type when the application has multiple user models configured, and custom roles were not honored as a result.
Close #3829
@akki-ng This patch is inspired by your #3823 but fixes a different and smaller problem. Could you please take a look at the proposed code changes too?
@ebarault If you can, then please review my changes too, they are related to you work on multi-user-model support.