Feat/websockets#1
Merged
elliotdotsol merged 15 commits intomainfrom Apr 11, 2026
Merged
Conversation
Replace the ad-hoc WS implementation with a typed, room-based protocol derived from the AsyncAPI spec. Types are auto-generated and rooms are validated by check-routes, matching the existing REST/webhook pattern. - Generic `subscribe(room, filters?)` / `unsubscribe(room)` with typed overloads (filters optional only for rooms where spec allows it) - `connect()` returns Promise<void>, `subscribe()` returns Promise with server ack (rejected filters, timeout handling) - `on()` returns disposer function for ergonomic React/framework cleanup - `removeAllListeners()` for bulk teardown - Configurable `subscribeTimeout` via StructWebSocketConfig - Auto-ping keepalive (30s), replay subscriptions on reconnect - AsyncAPI spec pipeline: fetch → generate types → check rooms/schemas - 9 rooms: trades, asset_prices, asset_window_updates, market_metrics, event_metrics, position_metrics, trader_pnl, accounts, order_book Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace the ad-hoc WS implementation with a typed, room-based protocol derived from the AsyncAPI spec. Types are auto-generated and rooms are validated by check-routes, matching the existing REST/webhook pattern. - Generic `subscribe(room, filters?)` / `unsubscribe(room)` with typed overloads (filters optional only for rooms where spec allows it) - `connect()` returns Promise<void>, `subscribe()` returns Promise with server ack (rejected filters, timeout handling) - `on()` returns disposer function for ergonomic React/framework cleanup - `removeAllListeners()` for bulk teardown - Configurable `subscribeTimeout` via StructWebSocketConfig - Auto-ping keepalive (30s), replay subscriptions on reconnect - AsyncAPI spec pipeline: fetch → generate types → check rooms/schemas - 9 rooms: trades, asset_prices, asset_window_updates, market_metrics, event_metrics, position_metrics, trader_pnl, accounts, order_book Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# Conflicts: # README.md # openapi/polymarket.json # package.json # src/generated/polymarket.ts # src/ws.ts
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.